Hello Maxim, On 17.02.23 08:31, Maxim Kochetkov wrote: > - ret = ns16550_init_iomem(dev, priv); > - if (ret) > - ret = ns16550_init_ioport(dev, priv); > - > if (ret) > return ret; ret is now uninitialized here. > > @@ -511,6 +507,10 @@ static int ns16550_probe(struct device *dev) > goto err; > } > > + ret = ns16550_init_iomem(dev, priv); > + if (ret) > + ret = ns16550_init_ioport(dev, priv); second ret is never checked. If you move the second if (ret), patch looks ok to me. jfyi, If you enable deep probe for your board/platform, clk_get() would automatically probe the clock driver if unavailable, so you shouldn't ever see -EPROBE_DEFER. Cheers, Ahmad > + > cdev = &priv->cdev; > cdev->dev = dev; > cdev->tstc = ns16550_tstc; -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
