Hello Renaud, On 10.02.23 16:57, Renaud Barbier wrote: > What about soc/fsl/immap_lsch2.h vs soc/fsl/immap_ls102xa.h. > Lots of similarities but also a lots of differences (when excluding the prefix LSCH2 and LS102XA) > Can I assume ccsr_scfg can be mapped to each other? > May be a question to NXP. Preferably, you'd use the already defined macros and for stuff where LS102x differs, you'd add a prefix, e.g. struct ls102x_ccsr_scfg. The goal should be to have as little duplication as possible and still be able to compile a file that includes both headers without them clashing. Cheers, Ahmad > > >> -----Original Message----- >> From: Sascha Hauer <sha@xxxxxxxxxxxxxx> >> Sent: 10 February 2023 12:26 >> To: Renaud Barbier <Renaud.Barbier@xxxxxxxxxx> >> Cc: Barebox List <barebox@xxxxxxxxxxxxxxxxxxx> >> Subject: Re: [PATCH 0/2] Initial LS1021-IOT board support >> >> ***NOTICE*** This came from an external source. Use caution when >> replying, clicking links, or opening attachments. >> >> On Fri, Feb 10, 2023 at 11:54:31AM +0000, Renaud Barbier wrote: >>> I have not tried yet. I was not sure if you like to have separate machine >> support as there are some differences in the SOC . >>> >>> I will merge it and send you a new patch. >> >> I like it better when it's merged, eventhough it's never compiled together as >> they are different compiler architectures. >> >> Sascha >> >>> >>>> -----Original Message----- >>>> From: Sascha Hauer <sha@xxxxxxxxxxxxxx> >>>> Sent: 10 February 2023 11:26 >>>> To: Renaud Barbier <Renaud.Barbier@xxxxxxxxxx> >>>> Cc: Barebox List <barebox@xxxxxxxxxxxxxxxxxxx> >>>> Subject: Re: [PATCH 0/2] Initial LS1021-IOT board support >>>> >>>> ***NOTICE*** This came from an external source. Use caution when >>>> replying, clicking links, or opening attachments. >>>> >>>> On Wed, Feb 08, 2023 at 01:26:21PM +0000, Renaud Barbier wrote: >>>>> The LS1021A-IOT is NXP ARMv7 Layerscape evaluation board. >>>>> >>>>> These patches provide a basic board support with: >>>>> - UART >>>>> - boot from SPI >>>>> - One Ethernet port - eth1* >>>>> >>>>> The content of the EEPROM having been lost so the MAC should be >>>>> set in the config file >>>>> >>>>> The code is ported from NXP U-boot 2021-04. Like U-boot, the >>>>> machine support i.e mac-lxxx lives in its own directory. However, >>>>> it is very similar to the ls1046a machine support. This migth be >>>>> merged. Please >>>> advise. >>>> >>>> It would be nice to have this merged to arch/arm/mach-layerscape. >>>> For example arch/arm/mach-layerscape/pblimage.c looks identical to >>>> your version. >>>> >>>> Have you tried merging it? If yes, which problems did you encounter? >>>> >>>> Sascha >>>> >>>> -- >>>> Pengutronix e.K. | | >>>> Steuerwalder Str. 21 | >>>> >> https://urldefense.com/v3/__http://www.pengutronix.de/__;!!HKOSU0g!C >>>> ZdG8RU9gQpSVfJzH_T4b8q5lFRdLrpGiJsD5H- >>>> H351N8ycvCriKuoi6quenVmESFrbU0Iw9qhIlb5z4ifTE$ | >>>> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | >>>> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | >>> >> >> -- >> Pengutronix e.K. | | >> Steuerwalder Str. 21 | >> https://urldefense.com/v3/__http://www.pengutronix.de/__;!!HKOSU0g!G >> os0mqldKVyCzyhvalaS58FEkUQ1osWODWWtH0- >> MC4aIxC0d2rtcUzK3DWcfHooti_U0whPPLXjo8H3Xl87E$ | >> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | >> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
