On Wed, Feb 01, 2023 at 07:13:24PM +0100, Ahmad Fatoum wrote: > On 24.01.23 21:01, Michael Grzeschik wrote: > > If the multiplier is 0 in the descriptor bitfield the multiplier count > > is one. For calculating the multiplier count the extra function > > usb_endpoint_maxp_mult should be used. Rework the dwc2 driver to use it > > and make multi packages work. > > > > While at it, we also remove the USB_EP_MAXP_MULT and > > USB_ENDPOINT_MAXP_MASK macros that would stay left unused and are > > defined in include/usb/ch9.ch anyway. > > > > Tested-by: Jules Maselbas <jmaselbas@xxxxxxxxx> > > Signed-off-by: Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx> > > This induces the same breakage as in v1, even a simple ACM gadget > fails: > > barebox@Linux Automation Test Automation Controller (TAC):/ usbgadget -a > udc0: registering UDC driver [g_multi] > multi_bind: creating ACM function > g_multi usbgadget: Multifunction Composite Gadget > g_multi usbgadget: g_multi ready > dwc2 49000000.usb-otg@xxxxxxxxxxx: bound driver g_multi > dwc2 49000000.usb-otg@xxxxxxxxxxx: new address 3 > g_multi usbgadget: high-speed config #1: Multifunction Composite Gadget > ERROR: dwc2 49000000.usb-otg@xxxxxxxxxxx: dwc2_ep_enable: No suitable fifo found > > > The other patch while maybe applicable to the kernel, doesn't do anything > for barebox. Please test barebox patches in barebox for v3. > > @Sascha, can you drop this series from next? Did that. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
