On Wed, Jan 25, 2023 at 08:33:57PM +0100, Marco Felsch wrote:
> Hi John,
>
> thanks for your patch.
>
> On 23-01-26, John Watts wrote:
> > The Kosagi Novena is an open source laptop released in 2014.
> >
> > This patch adds the initial project skeleton for running the PBL
> > and debugging over the UART2 port (labeled DEBUG on the board.)
> >
> > Signed-off-by: John Watts <contact@xxxxxxxxxx>
> > ---
> > arch/arm/boards/Makefile | 1 +
> > arch/arm/boards/novena/Makefile | 4 +
> > arch/arm/boards/novena/board.c | 26 +++++++
> > .../boards/novena/flash-header-novena.imxcfg | 6 ++
> > arch/arm/boards/novena/lowlevel.c | 73 +++++++++++++++++++
> > arch/arm/configs/imx_v7_defconfig | 1 +
> > arch/arm/dts/Makefile | 1 +
> > arch/arm/dts/imx6q-novena.dts | 4 +
> > arch/arm/mach-imx/Kconfig | 6 ++
> > images/Makefile.imx | 2 +
> > 10 files changed, 124 insertions(+)
> > create mode 100644 arch/arm/boards/novena/Makefile
> > create mode 100644 arch/arm/boards/novena/board.c
> > create mode 100644 arch/arm/boards/novena/flash-header-novena.imxcfg
> > create mode 100644 arch/arm/boards/novena/lowlevel.c
> > create mode 100644 arch/arm/dts/imx6q-novena.dts
> >
> > diff --git a/arch/arm/boards/Makefile b/arch/arm/boards/Makefile
> > index f47aea6602..50088886eb 100644
> > --- a/arch/arm/boards/Makefile
> > +++ b/arch/arm/boards/Makefile
> > @@ -19,6 +19,7 @@ obj-$(CONFIG_MACH_BEAGLEBONE) += beaglebone/
> > obj-$(CONFIG_MACH_CANON_A1100) += canon-a1100/
> > obj-$(CONFIG_MACH_CM_FX6) += cm-fx6/
> > obj-$(CONFIG_MACH_NITROGEN6) += boundarydevices-nitrogen6/
> > +obj-$(CONFIG_MACH_NOVENA) += novena/
> > obj-$(CONFIG_MACH_CCMX51) += ccxmx51/
> > obj-$(CONFIG_MACH_CCMX53) += ccxmx53/
> > obj-$(CONFIG_MACH_CFA10036) += crystalfontz-cfa10036/
> > + if (!running_from_ram()) {
> > + imx6_ungate_all_peripherals();
> > + setup_uart();
> > + load_barebox();
> > + } else {
> > + boot_barebox();
> > + }
>
> This could be re-written to:
>
> imx6_ungate_all_peripherals();
>
> if (IS_ENABLED(CONFIG_DEBUG_LL))
> setup_uart();
setup_uart() also calls pbl_set_putc() to support PBL console. This is
useful without CONFIG_DEBUG_LL enabled, so please call it
unconditionally.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
