On Mon, Jan 09, 2023 at 02:08:14PM +0100, Ahmad Fatoum wrote: > The sama5d4[devices].c files are for non-OF instantiation of platform > devices. We don't need anything out of these two files, so don't build > them when compiling for CONFIG_OFDEVICE. > > Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> > --- > arch/arm/mach-at91/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-at91/Makefile b/arch/arm/mach-at91/Makefile > index 390d49d03dee..b9fda00b2e1a 100644 > --- a/arch/arm/mach-at91/Makefile > +++ b/arch/arm/mach-at91/Makefile > @@ -30,6 +30,7 @@ obj-$(CONFIG_SOC_AT91SAM9G10) += at91sam9261.o at91sam9261_devices.o > ifeq ($(CONFIG_OFDEVICE),) > obj-$(CONFIG_SOC_AT91SAM9263) += at91sam9263.o at91sam9263_devices.o > obj-$(CONFIG_SOC_SAMA5D3) += sama5d3.o sama5d3_devices.o > +obj-$(CONFIG_SOC_SAMA5D4) += sama5d4.o sama5d4_devices.o > endif > lwl-$(CONFIG_SOC_AT91SAM9263) += sam9263_ll.o > lwl-$(CONFIG_SOC_SAMA5D2) += sama5d2_ll.o > @@ -39,4 +40,3 @@ obj-$(CONFIG_SOC_AT91SAM9G20) += at91sam9260.o at91sam9260_devices.o > obj-$(CONFIG_SOC_AT91SAM9G45) += at91sam9g45.o at91sam9g45_devices.o > obj-$(CONFIG_SOC_AT91SAM9X5) += at91sam9x5.o at91sam9x5_devices.o > obj-$(CONFIG_SOC_AT91SAM9N12) += at91sam9n12.o at91sam9n12_devices.o > -obj-$(CONFIG_SOC_SAMA5D4) += sama5d4.o sama5d4_devices.o This breaks compilation of sama5d4ek_defconfig and sama5d4_xplained_defconfig: arch/arm/boards/sama5d4_xplained/sama5d4_xplained.o: in function `sama5d4_xplained_mem_init': arch/arm/boards/sama5d4_xplained/sama5d4_xplained.c:251: undefined reference to `at91_add_device_sdram' Several more undefined references follow. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
