On 04.01.23 13:01, Sascha Hauer wrote: > On Fri, Dec 23, 2022 at 10:10:48AM +0100, Marco Felsch wrote: >> Hi Ahmad, >> >> On 22-12-22, Ahmad Fatoum wrote: >>> Give the defconfig some color by enabling console colors during startup, >>> i.MX6 parallel LCD driver, backlight and some more options that were >>> noticed missing during debugging a skov-imx6 issue. >> >> I'm okay with enabling a few command and the colored console per default >> but the video-output use-case isn't really common and just increases the >> size of the barebox image. > > This patch indeed increases the binary size, like for example > barebox-zii-vf610-dev.img from 743788 bytes to 790858 bytes. > However, the enabled video options are only responsible for a small > fraction of it. With disabling the video options again the image > size shrinks to 788738 bytes. > > I've always seen the imx_*_defconfig files as mostly full featured > configs to get good compile coverage and a barebox that just works > for as many cases as possible. From that perspective I think it's ok > to add more options. Feel free to pick 1-4/6 and I'll look again into 5-6 and resend as appropriate. > > Sascha > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |