Hi Ahmad.
On Mon, Dec 19, 2022 at 07:18:39PM +0100, Ahmad Fatoum wrote:
> The value of the native-mode property is supposed to be a phandle to
> the entry in question, but instead the full node path was used because
> the <angle brackets> were missing. Fix this. This should not involve any
> functional change as the default mode would've been the first element,
> which is the same element the malformed native-mode now points at.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
> ---
> arch/arm/dts/imx6qdl-skov-imx6.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/dts/imx6qdl-skov-imx6.dtsi b/arch/arm/dts/imx6qdl-skov-imx6.dtsi
> index f4610ee1e7ba..156722b95a3c 100644
> --- a/arch/arm/dts/imx6qdl-skov-imx6.dtsi
> +++ b/arch/arm/dts/imx6qdl-skov-imx6.dtsi
> @@ -146,7 +146,7 @@
> };
>
> display-timings {
> - native-mode = &l2rt;
> + native-mode = <&l2rt>;
The fix is OK, but could you also fix the other similar bugs in the
tree?
A quick grep identified the following that all looks wrong:
arch/arm/dts/imx6q-var-custom.dts: native-mode = &claawvga;
arch/arm/dts/imx6qdl-skov-imx6.dtsi: native-mode = &l2rt
arch/arm/dts/imx6qdl-skov-imx6.dtsi: native-mode = &mi1010ait_1cp1;
I took a quick look, and to my surprise I found no similar bugs in the
kernel.
Sam
