On Wed, Nov 02, 2022 at 11:07:41AM +0100, Oleksij Rempel wrote: > Enable poromisc mode by default to allow using multiple MAC address on > same FEC interfaces. s/poromisc/promiscuous/ > > We already use poromisc mode on designware stmmac, so it will make > behavior more consistent on different systems. > > Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> > --- > drivers/net/fec_imx.c | 3 +++ > drivers/net/fec_imx.h | 1 + > 2 files changed, 4 insertions(+) > > diff --git a/drivers/net/fec_imx.c b/drivers/net/fec_imx.c > index 673555a48a..9aa4b4f595 100644 > --- a/drivers/net/fec_imx.c > +++ b/drivers/net/fec_imx.c > @@ -262,6 +262,9 @@ static int fec_init(struct eth_device *dev) > */ > rcntl = FEC_R_CNTRL_MAX_FL(1518); > > + /* Set promisc mode to make switches with different ethaddr work */ > + rcntl |= FEC_R_CNTRL_PROMISC; > + Shouldn't we rather enable promiscuous mode in an extra callback? In the end we want promiscuous mode only in specific cases, not generally. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
