On 22-10-19, Sascha Hauer wrote: > On Fri, Oct 14, 2022 at 06:35:28PM +0200, Marco Felsch wrote: > > As written in the state.rst documentation, state will silently fail if > > the STATE_DRV is not selected. So enabling state without the state > > driver is useless. Fix this by selecting the STATE_DRV if STATE is > > selected. > > > > Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx> > > --- > > common/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/common/Kconfig b/common/Kconfig > > index fb2bf49683..4654a5cfaf 100644 > > --- a/common/Kconfig > > +++ b/common/Kconfig > > @@ -1016,6 +1016,7 @@ config STATE > > select ENVIRONMENT_VARIABLES > > select OFTREE > > select PARAMETER > > + select STATE_DRV > > STATE_DRV depends on OFDEVICE, so that should be selected here as well. Arg.. didn't checked that. > I am thinking about moving the state driver and the common state stuff > together into a single directory like drivers/state/. That would make it > more obvious that these belong together for both developers and users. > > What do you think? +1 from my side. Regards, Marco
