On Tue, Sep 27, 2022 at 07:22:17PM +0200, Enrico Scholz wrote: > It should warn when condition does **not** hold > > Signed-off-by: Enrico Scholz <enrico.scholz@xxxxxxxxxxxxxxxxx> > --- > lib/zstd/common/zstd_deps.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. That fixes only the warnings, not the regression, right? Sascha > > diff --git a/lib/zstd/common/zstd_deps.h b/lib/zstd/common/zstd_deps.h > index 7a5bf44839c9..f06df065dec0 100644 > --- a/lib/zstd/common/zstd_deps.h > +++ b/lib/zstd/common/zstd_deps.h > @@ -84,7 +84,7 @@ static uint64_t ZSTD_div64(uint64_t dividend, uint32_t divisor) { > > #include <linux/kernel.h> > > -#define assert(x) WARN_ON((x)) > +#define assert(x) WARN_ON(!(x)) > > #endif /* ZSTD_DEPS_ASSERT */ > #endif /* ZSTD_DEPS_NEED_ASSERT */ > -- > 2.37.3 > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |