I ran scan-build while building barebox for sandbox with clang and patched some of the reported issues. Ahmad Fatoum (32): clk: define stub implementation for clk_get_parent clk: have SCMI and SiFive clock controllers depend on COMMON_CLK meminfo: support SANDBOX build with DEBUG log level net: phy: micrel: drop useless assignment of dummy read mci: core: drop useless assignment nvmem: core: propagate read failure fs: remove never-read initializer in mount_all() usb: otg: always propagate failure to register parameters usb: dwc2: gracefully handle unknown hs_phy_type state: propagate failure to fixup enum32 into DT of: silence warning about never-read error assignment commands: trigger: drop unused variable commands: tutorial: fix memory leak bthread: fix null pointer dereference in error path common: env: drop never-read initialization of: refactor for of_fixup_reserved_memory() for clarity password: avoid static analyzer false positive regmap-mmio: regmap_mmio_get_min_stride: unify branches for readability crypto: caam - delete unused variable misc: ubootvar: always initialize struct ubootvar_data::flag nvmem: core: drop always true condition of: fdt: gracefully handle out-of-place properties of: overlay: drop unused variable of_overlay_apply_dir() of: partition: drop unused variable serial: ns16550_pci: drop useless assignment phy: core: drop useless else clause fs: ext4: ext_barebox: handle ext_get_inode() errors fs: fat: propagate f_lseek failure fs: drop duplicate follow_managed() call lib: parse_area_spec: guard against NULL pointer dereference net: ping: propagate failure net: fastboot: keep error message initialized at all times commands/trigger.c | 5 +---- commands/tutorial.c | 7 ++---- common/bthread.c | 2 ++ common/env.c | 2 +- common/meminfo.c | 6 ++++-- common/oftree.c | 6 ++++-- common/password.c | 4 ++-- common/state/state_variables.c | 2 ++ drivers/base/regmap/regmap-mmio.c | 2 +- drivers/clk/Kconfig | 5 ++++- drivers/crypto/caam/jr.c | 2 -- drivers/mci/mci-core.c | 2 +- drivers/misc/ubootvar.c | 2 +- drivers/net/phy/micrel.c | 2 +- drivers/nvmem/core.c | 8 ++++++- drivers/of/fdt.c | 2 +- drivers/of/overlay.c | 3 --- drivers/of/partition.c | 3 --- drivers/of/resolver.c | 1 + drivers/phy/phy-core.c | 2 -- drivers/serial/serial_ns16550_pci.c | 2 +- drivers/usb/dwc2/core.c | 3 +++ drivers/usb/otg/otgdev.c | 33 ++++++++++++++++------------- fs/ext4/ext_barebox.c | 18 ++++++++++------ fs/fat/fat.c | 5 +++++ fs/fs.c | 15 ++++--------- include/linux/clk.h | 20 ++++++++++------- lib/misc.c | 2 ++ net/fastboot.c | 2 ++ net/net.c | 2 +- 30 files changed, 95 insertions(+), 75 deletions(-) -- 2.30.2