On Thu, Jul 14, 2022 at 10:54:47AM +0200, Ahmad Fatoum wrote: > On 14.07.22 10:45, Sascha Hauer wrote: > > On Wed, Jul 13, 2022 at 12:09:22PM +0200, Ahmad Fatoum wrote: > >> So far, we only supported zstd in squashfs and ubifs. Add support > >> everywhere else: In PBL for decompressing barebox proper, in uncompress > >> for compression arbitrary files and for bootm to decompress zstd > >> kernel images. > > > > Have you tested this with the uncompress command? > > > > a zstd compressed barebox works here, but using uncompress > > on a zstd compressed file results in: > > > > ZSTD-compressed data is corrupt > > > > or sometimes: > > > > Out of memory while allocating ZSTD_DStream > > I didn't test the uncompress command, no. How did you create > the zstd file? just a plain 'zstd foo' without any options. > The Linux zstd decompression expects the size > to be trailing the decompressed data and doesn't parse the > zstd header. See the comment in scripts/Makefile.lib for details. When it's expected that we can't use the uncompress command on zstd files then we shouldn't support it. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
