On Tue, Jul 12, 2022 at 06:45:10PM +0200, Uwe Kleine-König wrote: > Hello, > > while updating barebox from 2021.07.0 to 2022.05.0 I hit a regression: > > The behaviour of 2022.05.0 looks as follows: > > bootloader: automount -d /mnt/usbstorage 'usb && if [ -e /dev/disk0.0 ]; then mount /dev/disk0.0 /mnt/usbstorage; elif [ -e /dev/disk0 ]; then mount /dev/disk0 /mnt/usbstorage; fi' > bootloader: ls /mnt/usbstorage/ > > Without an USB drive this hangs until the watchdog resets the board. I > guess the problem is that the automount script is called again and again > because nothing was mounted. I just tried 2021.07.0 and the behaviour seems to be the same. I don't think it's a regression. automount -d /mnt/foo true ls /mnt/foo makes barebox hang. That shouldn't happen of course. > > I can workaround that problem by doing: > > bootloader: automount -d /mnt/usbstorage 'usb && if [ -e /dev/disk0.0 ]; then mount /dev/disk0.0 /mnt/usbstorage; elif [ -e /dev/disk0 ]; then mount /dev/disk0 /mnt/usbstorage; else false; fi' > bootloader: ls /mnt/usbstorage/ > running automount command 'usb && if [ -e /dev/disk0.0 ]; then mount /dev/disk0.0 /mnt/usbstorage; elif [ -e /dev/disk0 ]; then mount /dev/disk0 /mnt/usbstorage; else false; fi' failed > ls: /mnt/usbstorage/: No such device > running automount command 'usb && if [ -e /dev/disk0.0 ]; then mount /dev/disk0.0 /mnt/usbstorage; elif [ -e /dev/disk0 ]; then mount /dev/disk0 /mnt/usbstorage; else false; fi' failed > > but there is still something non-optimal. > > I can look into that, but I'm not entirely sure what the right behaviour > is. > > Should a command that doesn't mount something considered to have failed? > (I think that's how it was with 2021.07.0.) That sounds promising. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
