On Tue, Jun 28, 2022 at 10:23:01AM +0200, Ahmad Fatoum wrote: > On 28.06.22 10:04, Alexander Shiyan wrote: > > Signed-off-by: Alexander Shiyan <eagle.alexander923@xxxxxxxxx> > > Reviewed-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> > > > - if (!IS_ENABLED(CONFIG_OFDEVICE)) > > + if (!IS_ENABLED(CONFIG_OFDEVICE) || !np) > > Nitpick: > > struct device_node *np = dev_of_node(dev); > > if (!np) > > is equivalent, but a bit less verbose. Applied with this change, thanks Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |