Re: [PATCH] common: reset_source: Remove of_get_reset_source_priority()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



чт, 9 июн. 2022 г. в 23:08, Michael Riesch <michael.riesch@xxxxxxxxxxxxxx>:
>
> Hi Alexander,
> On 6/8/22 07:12, Alexander Shiyan wrote:
> > of_get_reset_source_priority() has no users,
> > so it can be safely removed.
> >
> > Signed-off-by: Alexander Shiyan <eagle.alexander923@xxxxxxxxx>
> > ---
> >  common/reset_source.c  | 20 +++-----------------
> >  include/reset_source.h |  7 -------
> >  2 files changed, 3 insertions(+), 24 deletions(-)
> >
> > diff --git a/common/reset_source.c b/common/reset_source.c
> > index 3554cbd0fb..dccb683231 100644
> > --- a/common/reset_source.c
> > +++ b/common/reset_source.c
> > @@ -76,7 +76,9 @@ EXPORT_SYMBOL(reset_source_set_prinst);
> >
> >  void reset_source_set_device(struct device_d *dev, enum reset_src_type st)
> >  {
> > -     int priority = of_get_reset_source_priority(dev->device_node);
> > +     unsigned int priority = RESET_SOURCE_DEFAULT_PRIORITY;
> > +
> > +     of_property_read_u32(node, "reset-source-priority", &priority);
>
> This seems to break my build:
> barebox/common/reset_source.c:81:30: error: 'node' undeclared (first use
> in this function)
>    81 |         of_property_read_u32(node, "reset-source-priority",
> &priority);
>       |                              ^~~~
>
> Should "node" be replaced by "dev->device_node"?

Hello.

You're right.
Unfortunately, I do not yet see this patch in the next branch to create a fixup.

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox




[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux