Re: [PATCH] ARM: OMAP: xload: Fix compile without CONFIG_MTD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02.06.22 10:59, Alexander Shiyan wrote:
> Hello.
> 
> It's just the result of the my master branch not being updated
> from remote before I made the changes... Sorry :)
> 
> чт, 2 июн. 2022 г. в 11:07, Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>:
>> On 01.06.22 09:14, Alexander Shiyan wrote:
>>> arm-linux-ld: arch/arm/mach-omap/xload.o: in function read_mtd_barebox':
>>> /home/ARM/barebox/arch/arm/mach-omap/xload.c:75: undefined reference to mtd_peb_read_file'
>>
>> Am I missing something or does this patch just change
>>
>>   if (0) {

Typo: if (1)

>>     return NULL;
>>   }
>>
>>   /* something */;
>>   return to;
>>
>> into
>>
>>   if (0) {
>>     /* something */
>>     return to;
>>   }
>>   return NULL;
>>
>>
>> This shouldn't really make a difference. How old is your GCC?

i.e. this patch can be dropped again?

> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox




[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux