Hello Marco, On 23.05.22 10:00, Marco Felsch wrote: > Hi Ahmad, > > On 22-05-23, Ahmad Fatoum wrote: >> A successful probe results in two lines logged: >> >> usb251xb usb2514b0: Hub configuration was successful. > > The configuration (and this line) can be skipped if you specify > "skip-config". > >> usb251xb usb2514b0: Hub probed successfully >> >> There is no case where the first line is printed, but not the other and >> they say about the same thing anyway, so drop the latter. > > The config step can fail. What about lower down the log level for the > config step to dev_dbg() instead? If the config step fails we will get an error message from driver core. A driver with skip-config doesn't do anything useful that warrants a probed successfully message, so I think it's safe to drop it. Cheers, Ahmad > > Regards, > Marco > > >> >> Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> >> --- >> drivers/usb/misc/usb251xb.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c >> index 4871faf451ce..8d60f19e1355 100644 >> --- a/drivers/usb/misc/usb251xb.c >> +++ b/drivers/usb/misc/usb251xb.c >> @@ -639,8 +639,6 @@ static int usb251xb_probe(struct usb251xb *hub) >> return err; >> } >> >> - dev_info(dev, "Hub probed successfully\n"); >> - >> return 0; >> } >> >> -- >> 2.30.2 >> >> >> _______________________________________________ >> barebox mailing list >> barebox@xxxxxxxxxxxxxxxxxxx >> http://lists.infradead.org/mailman/listinfo/barebox >> > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
