Re: [PATCH] ARM: OMAP: debug_ll: Use Kconfig UART base address

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



чт, 5 мая 2022 г. в 11:13, Sascha Hauer <sha@xxxxxxxxxxxxxx>:
> Hi Alexander,
> On Thu, May 05, 2022 at 10:36:04AM +0300, Alexander Shiyan wrote:
> > Signed-off-by: Alexander Shiyan <eagle.alexander923@xxxxxxxxx>
> > ---
> >  arch/arm/boards/afi-gf/lowlevel.c            |  2 +-
> >  arch/arm/boards/beagle/lowlevel.c            |  2 +-
> >  arch/arm/boards/beaglebone/lowlevel.c        |  2 +-
> >  arch/arm/boards/myirtech-x335x/lowlevel.c    |  2 +-
> >  arch/arm/boards/phytec-som-am335x/lowlevel.c |  2 +-
> >  arch/arm/boards/vscom-baltos/lowlevel.c      |  2 +-
> >  arch/arm/boards/wago-pfc-am35xx/lowlevel.c   |  2 +-
> >  arch/arm/mach-omap/include/mach/debug_ll.h   | 43 ++++++++++++--------
> >  8 files changed, 33 insertions(+), 24 deletions(-)
> >
> > diff --git a/arch/arm/boards/afi-gf/lowlevel.c b/arch/arm/boards/afi-gf/lowlevel.c
> > index de40f6c5af..9e86b29b2d 100644
> > --- a/arch/arm/boards/afi-gf/lowlevel.c
> > +++ b/arch/arm/boards/afi-gf/lowlevel.c
> > @@ -230,7 +230,7 @@ static noinline int gf_sram_init(void)
> >
> >       am33xx_uart_soft_reset((void *)AM33XX_UART2_BASE);
> >       am33xx_enable_uart2_pin_mux();
> > -     omap_uart_lowlevel_init((void *)AM33XX_UART2_BASE);
> > +     omap_uart_lowlevel_init();
>
> I don't think removing the base address from omap_uart_lowlevel_init()
> is a step forward. CONFIG_DEBUG_LL is only one possible usecase for this
> function, another one is for regular early console with pbl_set_putc().

Ok. Please take a look at the patch in the next message, is this how
it should be?

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox




[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux