чт, 21 апр. 2022 г. в 10:35, Sascha Hauer <sha@xxxxxxxxxxxxxx>:
>
> On Wed, Apr 20, 2022 at 12:53:22PM +0300, Alexander Shiyan wrote:
> > The MYD-AM335X Development Board designed by MYIR is a high-performance
> > ARM Evaluation Module (EVM) using the MYC-AM335X CPU module as the core
> > controller board. It is based on up to 1GHz Texas Instruments (TI)
> > Sitara AM335x family of ARM Cortex-A8 Microprocessors (MPUs) that deliver
> > high DMIPs at a low cost while also delivering optional 3D graphics
> > acceleration and key peripherals.
> >
> > Signed-off-by: Alexander Shiyan <eagle.alexander923@xxxxxxxxx>
...
> > +static struct omap_barebox_part myir_barebox_part = {
> > + .nand_offset = SZ_128K,
> > + .nand_size = SZ_512K,
> > +};
>
> Isn't this a bit too small? Putting a barebox into 128k seems very
> ambicous.
The boot image (MLO) should not exceed 128 KB in size,
so I think this should be enough.
In any case this size is already specified for the boot partition
in kernel DTS for this board. :)
...
> > +++ b/arch/arm/boards/myirtech-x335x/defaultenv-myirtech-x335x/nv/linux.bootargs.console
> > @@ -0,0 +1 @@
> > +console=ttyS0,115200n8 earlyprintk
>
> The console= part shouldn't be needed. barebox should add a console=
> parameter matching the current barebox console automatically.
>
> I wouldn't add the earlyprintk by default. It might break booting when
> the kernel is not exactly configured for your board. Anyway, that's
> personal taste.
OK.
...
> > diff --git a/arch/arm/configs/myirtech_am335x_myd_defconfig b/arch/arm/configs/myirtech_am335x_myd_defconfig
>
> Do you need this config? I rather prefer to add the board to some
> existing config, omap_defconfig in this case.
OK.
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
