Hello Joacim, On 28.02.22 17:57, Joacim Zetterling wrote: > This driver is ported from the linux kernel and adapted to barebox > for the NXP IMX8 platforms. > > This commit add support for the NXP IMX8 Flex SPI controller in master > mode. Up to four slave devices can be connected on two buses with two > chip selects each. This controller does not support generic SPI messages > and only supports the high-level SPI memory interface. > > Tested on the NXP IMX8MN-EVK evaluation board as well as on a > IMX8MN custom board supporting a Micron N25Q00 QSPI flash. I haven't reviewed the driver itself, but some general feedback below. > > Signed-off-by: Joacim Zetterling <joacim.zetterling@xxxxxxxxxxxx> > --- > drivers/spi/Kconfig | 10 + > drivers/spi/Makefile | 1 + > drivers/spi/spi-nxp-fspi.c | 1061 ++++++++++++++++++++++++++++ > dts/Bindings/spi/spi-nxp-fspi.yaml | 1 + > 4 files changed, 1073 insertions(+) > create mode 100644 drivers/spi/spi-nxp-fspi.c > > diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig > index b0137d21e073..f7e92665d5a8 100644 > --- a/drivers/spi/Kconfig > +++ b/drivers/spi/Kconfig > @@ -114,6 +114,16 @@ config DRIVER_SPI_STM32 > Enable the STM32 Serial Peripheral Interface (SPI) driver for STM32MP > SoCs. > > +config SPI_NXP_FLEXSPI > + tristate "NXP Flex SPI controller" > + depends on ARCH_IMX8M || HAS_IOMEM HAS_IOMEM doesn't exist in barebox. You can replace this with COMPILE_TEST > diff --git a/dts/Bindings/spi/spi-nxp-fspi.yaml b/dts/Bindings/spi/spi-nxp-fspi.yaml > index 283815d59e85..62930d0cf43f 100644 > --- a/dts/Bindings/spi/spi-nxp-fspi.yaml > +++ b/dts/Bindings/spi/spi-nxp-fspi.yaml > @@ -17,6 +17,7 @@ properties: > enum: > - nxp,imx8dxl-fspi > - nxp,imx8mm-fspi > + - nxp,imx8mn-fspi > - nxp,imx8mp-fspi > - nxp,imx8qxp-fspi > - nxp,lx2160a-fspi dts/ is imported from Linux as-is. You shouldn't edit stuff there. Cheers, Ahmad -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
