Hi Frank,
On Fri, Feb 11, 2022 at 10:11:14AM +0100, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
>
> Add tsadc and spi node from linux.
>
> Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
> ---
> arch/arm/dts/rk3568-pinctrl.dtsi | 9 ++++++++
> arch/arm/dts/rk3568.dtsi | 35 ++++++++++++++++++++++++++++++++
> 2 files changed, 44 insertions(+)
>
> diff --git a/arch/arm/dts/rk3568-pinctrl.dtsi b/arch/arm/dts/rk3568-pinctrl.dtsi
> index a588ca95ace2..8f90c66dd9e9 100644
> --- a/arch/arm/dts/rk3568-pinctrl.dtsi
> +++ b/arch/arm/dts/rk3568-pinctrl.dtsi
> @@ -3108,4 +3108,13 @@
> <4 RK_PA0 3 &pcfg_pull_none_drv_level_2>;
> };
> };
> +
> + tsadc {
> + /omit-if-no-ref/
> + tsadc_pin: tsadc-pin {
> + rockchip,pins =
> + /* tsadc_pin */
> + <0 RK_PA1 0 &pcfg_pull_none>;
> + };
> + };
> };
> diff --git a/arch/arm/dts/rk3568.dtsi b/arch/arm/dts/rk3568.dtsi
> index 0f19d3f0c0c3..6afd95b01c0c 100644
> --- a/arch/arm/dts/rk3568.dtsi
> +++ b/arch/arm/dts/rk3568.dtsi
> @@ -772,6 +772,21 @@
> clock-names = "tclk", "pclk";
> };
>
> + spi3: spi@fe640000 {
> + compatible = "rockchip,rk3568-spi", "rockchip,rk3066-spi";
> + reg = <0x0 0xfe640000 0x0 0x1000>;
> + interrupts = <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru CLK_SPI3>, <&cru PCLK_SPI3>;
> + clock-names = "spiclk", "apb_pclk";
> + dmas = <&dmac0 26>, <&dmac0 27>;
> + dma-names = "tx", "rx";
> + pinctrl-names = "default";
> + pinctrl-0 = <&spi3m0_cs0 &spi3m0_cs1 &spi3m0_pins>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
When you asked me if you should keep tsadc/spi3 in your board dts I
didn't understand that these are missing in rk3568.dtsi.
Adding these nodes when barebox doesn't use them has no gain for us. I
won't take this patch and removed references to spi3/tsadc from your
board patch while applying.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
