Hello Frank,
On 23.01.22 17:51, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
> +/ {
> + model = "Rockchip RK3568 Bananapi R2 Pro Board";
> + compatible = "rockchip,rk3568-bpi-r2pro", "rockchip,rk3568";
> +
> + aliases {
> + emmc = &sdhci;
> + sd = &sdmmc0;
> + };
> +
> + chosen: chosen {
You can drop the label.
> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
> index 3c6b3dd9b531..7d54f357cfda 100644
> --- a/arch/arm/mach-rockchip/Kconfig
> +++ b/arch/arm/mach-rockchip/Kconfig
> @@ -68,6 +68,12 @@ config MACH_RK3568_EVB
> help
> Say Y here if you are using a RK3568 EVB
>
> +config MACH_RK3568_R2PRO
> + select ARCH_RK3568
> + bool "RK3568 R2PRO"
> + help
> + Say Y here if you are using a RK3568 Bananpi R2 Pro
Banana Pi BPI-R2 Pro*. Perhaps include the Banana Pi bit in the prompt
text as well?
> +
> config MACH_PINE64_QUARTZ64
> select ARCH_RK3568
> bool "Pine64 Quartz64"
> diff --git a/dts/Bindings/arm/rockchip.yaml b/dts/Bindings/arm/rockchip.yaml
> index 4aed16176434..109f885d970f 100644
> --- a/dts/Bindings/arm/rockchip.yaml
> +++ b/dts/Bindings/arm/rockchip.yaml
dts/ is synchronized with Linux, so patches here are not accepted in barebox.
You can add new bindings to Documentation/devicetree/bindings/, although
boards are usually not documented in the bindings, but instead in board
docs:
Could you add an entry to Documentation/boards/rockchip.rst -> Rockchip RK356x
-> Supported Boards?
And enabling the board in arch/arm/configs/rockchip_v8_defconfig
would be nice as well.
Cheers,
Ahmad
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
