On Mon, Jan 03, 2022 at 05:11:53PM +0100, Sam Ravnborg wrote: > Hi Ahmad, > > On Mon, Jan 03, 2022 at 12:57:14PM +0100, Ahmad Fatoum wrote: > > The base address for MMIO writes was the address of the resource struct, > > not the start address pointed at by it. > > > > Change untested, but it doesn't look like this driver could ever have > > worked. > > You are right that I never got around to see backlight dimming work. > I recall that backlight worked and then the pwm driver was added as part > of several other patches for barebox. > I should have dropped the patch until I had seen it actually work. > > But nice catch! > > I may try to dust of the skov board where this is used to test it. > But these days I play with an i.MX6 board which has a bit more power, > so no promises. For the patch btw: Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx> _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
