On Mon, Nov 01, 2021 at 05:40:53PM +0000, Ian Abbott wrote: > Since commit 90bdf1e5d1e4 ("mci: dw_mmc: match against StarFive MMC > compatibles"), the dw_mmc driver requires a reset line called "reset". > The slightly earlier commit a3cf324593ea ("mci: dw_mmc: add optional > reset line") introduced the reset line support, but made it optional. > > The device tree node for SoCFPGA's MMC device has the "resets" property, > but is missing the "reset-names" property, so MMC no longer works. > Barebox produces the error message: > > ERROR: dw_mmc ff704000.dwmmc0@xxxxxxxxxxx: probe failed: Invalid argument > > Add the missing "reset-names" property to the "&mmc" node in > "arch/arm/dts/socfpga.dtsi". It probably needs fixing in the upstream > Linux device tree sources too! The reset binding lists reset-names as an optional property, so it seems our reset code needs fixing and not the dtsi file. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox