As documented in 90bdf1e5d1e4 ("mci: dw_mmc: match against StarFive MMC compatibles"), it was intended for the reset to remain optional as to not break existing users. Unfortunately, my later a3cf324593ea ("mci: dw_mmc: add optional reset line") didn't heed that and made it required, breaking SoCFPGA DW-MMC use as a result. Revert that line to fix the regression. Fixes: a3cf324593ea ("mci: dw_mmc: add optional reset line") Reported-by: Ian Abbott <abbotti@xxxxxxxxx> Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> --- drivers/mci/dw_mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mci/dw_mmc.c b/drivers/mci/dw_mmc.c index b402090ab3cb..86c4f43e88f5 100644 --- a/drivers/mci/dw_mmc.c +++ b/drivers/mci/dw_mmc.c @@ -572,7 +572,7 @@ static int dw_mmc_probe(struct device_d *dev) rst = reset_control_get(dev, "reset"); if (IS_ERR(rst)) { - return PTR_ERR(rst); + dev_warn(dev, "error claiming reset: %pe\n", rst); } else if (rst) { reset_control_assert(rst); udelay(10); -- 2.30.2 _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox