Re: [PATCH 6/9] usb: dwc3: Clarify error message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 11, 2021 at 10:43:55AM -0700, Trent Piepho wrote:
> On Mon, Oct 11, 2021 at 1:04 AM Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote:
> >         case DWC3_GHWPARAMS0_MODE_GADGET:
> >                 if (IS_ENABLED(CONFIG_USB_DWC3_HOST)) {
> >                         dev_err(dev,
> > -                               "Controller does not support host mode.\n");
> > +                               "This barebox does not support DWC3 host mode.\n");
> 
> Aren't these messages backward?  The hardware is set to device mode,
> CONFIG_USB_DWC3_HOST means, "Support only host mode," so it should
> fail because Barebox does not support device mode.

Let's drop this patch. I misread the message as "We want to do device
mode, but only host mode is compiled in", but really it says "Controller
can only do device mode, but we have only host mode complied in". I
wasn't aware that there are DWC3 cores with only host or only device
mode supported.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux