Hi Ahmad, I Just thought I should let you know that I won't be able to act on your feedback for a while since something else came along with a higher priority. I'll send the patches with corrections at a later date. best, Marcelo On Thu, Sep 16, 2021 at 6:21 PM Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> wrote: > > Hi Marcelo, > > On 16.09.21 20:01, Marcelo Politzer wrote: > >> Like this? :-) > >> > >> https://www.barebox.org/jsbarebox/ > > > > That is cool! > > :> > > >>> OK, I'll clean this up and send it as two patches: > >>> - serial_sbi > >>> - cartesi (board) > >> > >> Sounds good. > > > > Patches attached, please review at your convenience. > > Please resend without attachment if possible (e.g. with git send-email). > This makes it easier to review. > > Some comments: > > - Signed-off-by is required, just as with Linux. See https://developercertificate.org/ > - A short commit message would be nice > - BOARD_CARTESI should depend on SOC_VIRT for uniformity with other boards > - Can you change device tree compatible? Generic boards should remain generic > and not contain vendor-specific stuff. > - Please add your new Kconfig options to virt64_defconfig. That way you can build > and use the same image for all Virt-based boards (You can still use a different > config in your BSP of course) > > Serial driver: > > - remove DEBUG defines > - depends on RISCV (otherwise there is no <asm/sbi.h>) > - You don't need to implement flush and setbrg > - ucb,htif0 is an unrelated device, but there is no device tree > node, you can bind to. You can register a device in sbi_init > and match against that. See riscv-timer for an example > - I don't understand the point of the ring buffer. A command would > be nice (e.g. This is needed, because SBI lacks a FIFO or such) > - to_priv unused > > Cheers, > Ahmad > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
