On 03.08.21 11:44, Rouven Czerwinski wrote: > If the OF_RESERVE_ENTRY_FLAG_XN flag is passed while creating the > entry, a subsequent commit will use this information in the mmu to map > the area as non-executable. A changelog would've been nice. > diff --git a/arch/arm/mach-layerscape/ppa.c b/arch/arm/mach-layerscape/ppa.c > index d962fba751..6e61766e54 100644 > --- a/arch/arm/mach-layerscape/ppa.c > +++ b/arch/arm/mach-layerscape/ppa.c > @@ -130,7 +130,7 @@ int ls1046a_ppa_init(resource_size_t ppa_start, resource_size_t ppa_size) > if (ret) > return ret; > > - of_add_reserve_entry(ppa_start, ppa_end); > + of_add_reserve_entry(ppa_start, ppa_end, 0); Same comment as last time. I believe this should be mapped _XN too, but that should be tested first. Thus: Reviewed-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> If you respin the series, you may want to add a TODO comment here, so it is not forgotten. Cheers, Ahmad -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
