On Fri, 2021-07-16 at 14:21 +0200, Marc Kleine-Budde wrote:
> In commit
>
> > 655e085e3a22 ("crypto: caam - Always do rng selftest")
>
> the kconfig option CONFIG_CRYPTO_DEV_FSL_CAAM_RNG_SELF_TEST was
> removed, which resulted in the pr_debug() never being executed. Remove
> the IS_ENABLED() to restore the original behavior, i.e. to not print
> the HAB error Event if it is the known RNG self-test failure.
>
> Fixes: 655e085e3a22 ("crypto: caam - Always do rng selftest")
> Reported-by: Roland Hieber <rhi@xxxxxxxxxxxxxx>
> Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> ---
> drivers/hab/habv4.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/hab/habv4.c b/drivers/hab/habv4.c
> index c2acb81369d8..d58768fa5481 100644
> --- a/drivers/hab/habv4.c
> +++ b/drivers/hab/habv4.c
> @@ -553,8 +553,7 @@ static int habv4_get_status(const struct habv4_rvt *rvt)
> break;
>
> /* suppress RNG self-test fail events if they can be handled in software */
> - if (IS_ENABLED(CONFIG_CRYPTO_DEV_FSL_CAAM_RNG_SELF_TEST) &&
> - is_known_rng_fail_event(data, len)) {
> + if (is_known_rng_fail_event(data, len)) {
> pr_debug("RNG self-test failure detected, will run software self-test\n");
> } else {
> pr_err("-------- HAB Event %d --------\n", i);
Reviewed-by: Rouven Czerwinski <r.czerwinski@xxxxxxxxxxxxxx>
However I wonder if we need the pr_debug at all, since the selftests
are now always run, regardless of the HAB error. But I guess it's nice
to note that we detected the error and ran the software selftests.
- rcz
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
