Re: [PATCH 04/24] clk: introduce struct clk_hw

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 11, 2021 at 11:19:12AM +0200, Ahmad Fatoum wrote:
> Hello Sascha,
> 
> On 11.06.21 10:41, Sascha Hauer wrote:
> > On Fri, Jun 11, 2021 at 09:55:36AM +0200, Ahmad Fatoum wrote:
> >> Hello Sascha,
> >>
> >> On 02.06.21 11:54, Sascha Hauer wrote:
> >>
> >>> In Linux the ops in struct clk_ops take a struct clk_hw * argument
> >>
> >>> instead of a struct clk * argument as in barebox. With this taking
> >>
> >>> new clk drivers from Linux requires a lot of mechanical conversions.
> >>
> >>> Instead of doing this over and over again swallow the pill once and
> >>
> >>> convert the existing barebox code over to clk_hw.
> >>
> >>>
> >>
> >>> The implementation is a little different from Linux. In Linux struct clk
> >>
> >>> is only known to the core clock code. In barebox struct clk is
> >>
> >>> publically known and it is embedded into struct clk_hw. This allows
> >>
> >>> us to still use struct clk members in the clock drivers which we
> >>
> >>> currently still need, because otherwise this patch would be even
> >>
> >>> bigger.
> >>
> >>>
> >>
> >>> Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> >>
> >> drivers/clk/sifive, which was added recently doesn't have these changes
> >> and thus the build fails. To reproduce, without installed RISC-V toolchain, try:
> >>
> >>    ./test/emulate.pl --runtime=podman sifive_defconfig
> > 
> > Can't exec "tuxmake": No such file or directory at ./test/emulate.pl line 377.
> > 
> > Where do I get this from?
> 
> pip3 install tuxmake

Now it complains about missing podman... /me waits for Debian 11.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux