On 4/22/21 5:14 PM, Bastian Krause wrote: > On 4/15/21 5:31 PM, Lucas Stach wrote: >> Am Donnerstag, dem 15.04.2021 um 17:12 +0200 schrieb Sascha Hauer: >>> On Thu, Apr 15, 2021 at 04:59:30PM +0200, Lucas Stach wrote: >>>> Am Donnerstag, dem 15.04.2021 um 16:03 +0200 schrieb Sascha Hauer: >>>>> The SabreSD comes with different SoC variants. This patch adds support >>>>> for the i.MX6QP based board. the DCD data has been taken from U-Boot >>>>> 2021.04 >>>>> >>>>> Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> >>>>> --- >>>>> >>>> [...] >>>>> new file mode 100644 >>>>> index 0000000000..52cc8aa73b >>>>> --- /dev/null >>>>> +++ b/arch/arm/dts/imx6qp-sabresd.dts >>>>> @@ -0,0 +1,42 @@ >>>>> +/* >>>>> + * Copyright 2012 Freescale Semiconductor, Inc. >>>>> + * Copyright 2011 Linaro Ltd. >>>>> + * >>>>> + * The code contained herein is licensed under the GNU General Public >>>>> + * License. You may obtain a copy of the GNU General Public License >>>>> + * Version 2 or later at the following locations: >>>>> + * >>>>> + * http://www.opensource.org/licenses/gpl-license.html >>>>> + * http://www.gnu.org/copyleft/gpl.html >>>>> + */ >>>>> + >>>>> +#include <arm/imx6qp-sabresd.dts> >>>>> + >>>>> +/ { >>>>> + model = "Freescale i.MX6 Quad SABRE Smart Device Board"; >>>>> + compatible = "fsl,imx6q-sabresd", "fsl,imx6q"; >>>> >>>> I'm not sure I like this overwriting of the compatible string. AFAICS >>>> we don't have any instances for "fsl,imx6qp" compatible checks in >>>> either Barebox or Linux kernel, so it shouldn't cause any immediate >>>> damage, but this still feels wrong. >>> >>> It's overwritten with the same strings as the included upstream dts has. >>> Anyway, as you say overwriting them here seems wrong. I removed it. >> >> You had me confused for bit here, so I just checked and the compatible >> in the included upstream dts is different, as expected: >> >> compatible = "fsl,imx6qp-sabresd", "fsl,imx6qp"; >> >> So now that you removed those lines, does you board file need fixing >> for the different compatibles? > > My board works fine (bootspec-wise) with the dropped compatible. What's the state of this patch, Sascha? Regards, Bastian -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
