On 21-05-25 07:15, Sascha Hauer wrote:
> On Fri, May 21, 2021 at 06:34:32PM +0200, Marco Felsch wrote:
> > This allows us to control the output behaviour e.g. booting silently
> > to improve boot time.
> >
> > Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx>
> > ---
> > commands/mount.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/commands/mount.c b/commands/mount.c
> > index ff1d8bc5e5..bb2d1d60f4 100644
> > --- a/commands/mount.c
> > +++ b/commands/mount.c
> > @@ -74,7 +74,7 @@ static int do_mount(int argc, char *argv[])
> > if (IS_ERR(path))
> > return PTR_ERR(path);
> >
> > - printf("mounted /dev/%s on %s\n", devstr, path);
> > + pr_info("mounted /dev/%s on %s\n", devstr, path);
>
> Applied all except this one. This is the output from the mount command
> and as such it should be printed with printf.
Okay, just out of curiosity. Why should we avoid pr_*() for commands?
> I have no good idea to quiesce such output as we don't have any output
> redirection. Maybe we need an additional control knob for printf output.
This would be cool :)
Regards,
Marco
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
