On Tue, May 18, 2021 at 01:33:43PM +0200, Ahmad Fatoum wrote: > > On 18.05.21 12:57, Holger Assmann wrote: > > -$(call build_imx_habv4img, CONFIG_MACH_WEBASTO_CCBV2, start_imx6ul_ccbv2, webasto-ccbv2/flash-header-imx6ul-webasto-ccbv2, imx6ul-webasto-ccbv2) > > +$(call build_imx_habv4img, CONFIG_MACH_WEBASTO_CCBV2, start_imx6ul_ccbv2, webasto-ccbv2/flash-header-imx6ul-webasto-ccbv2-256, imx6ul-webasto-ccbv2-256m) > > + > > +$(call build_imx_habv4img, CONFIG_MACH_WEBASTO_CCBV2, start_imx6ul_ccbv2, webasto-ccbv2/flash-header-imx6ul-webasto-ccbv2-512, imx6ul-webasto-ccbv2-512m) > > I think this is the first board that uses the exact same entry point, but different > *.imxcfg. I built the patch to see if this actually does what it should and it > doesn't seem to be the case: both images/barebox-imx6ul-webasto-ccbv2-256m.img > and images/barebox-imx6ul-webasto-ccbv2-512m.img are identical.. This happens because we intermediately create the file images/start_imx6ul_ccbv2.pblb.imximg. We would have to create two different imx images, one for each config file. This doesn't fit into the build process currently, so let's go with v4 holger has sent. We could add IMD tags for the memsize like Phytec has done: BAREBOX_IMD_TAG_STRING(physom_mx6_memsize_SZ_256M, IMD_TYPE_PARAMETER, "memsize=256", 0); That would at least otherwise justify that we need different entry points ;) Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
