[BUG] mtd: cfi-flash: comparison of unsigned expression in '>= 0' is always true

[Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>]

Hi,

The new warning correctly flags following piece of code in
drivers/mtd/nor/cfi_flash.c:

/* loop through the sectors from the highest address
 * when the passed address is greater or equal to the sector address
 * we have a match
 */
flash_sect_t find_sector(struct flash_info *info, unsigned long addr)
{
        flash_sect_t sector;

        for (sector = info->sector_count - 1; sector >= 0; sector--) {
                if (addr >= info->start[sector])
                        break;
        }

        return sector;
}

If addr is indeed unmapped by info->start[*], this would be an infinite
loop. I don't know what the correct fix would be though. Any suggestions?

Cheers,
Ahmad

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox