Re: [PATCH v2 11/11] RISC-V: make it possible to build RV32I multi-image with DEBUG_LL=n

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hell Antony,

On 07.05.21 00:08, Antony Pavlov wrote:
> Building multi-image with these options:
> 
> CONFIG_ARCH_RV32I=y
> CONFIG_RISCV_M_MODE=y
> CONFIG_SOC_ERIZO=y
> CONFIG_BOARD_ERIZO_GENERIC=y
> CONFIG_SOC_LITEX=y
> CONFIG_BOARD_LITEX_LINUX=y
> CONFIG_DEBUG_LL=n
> 
> leads to the build error:
> 
> arch/riscv/boards/erizo/lowlevel.c: In function ‘__start_erizo_generic’:
> arch/riscv/boards/erizo/lowlevel.c:11:2: error: implicit declaration of
> function ‘debug_ll_ns16550_init’ [-Werror=implicit-function-declaration]
>    11 |  debug_ll_ns16550_init();
>       |  ^~~~~~~~~~~~~~~~~~~~~
> 
> This patch fixes the problem by using preprocessor's directive.

I noticed that too. I just sent out a fixup for this.

> 
> Signed-off-by: Antony Pavlov <antonynpavlov@xxxxxxxxx>
> ---
>  arch/riscv/boards/erizo/lowlevel.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/riscv/boards/erizo/lowlevel.c b/arch/riscv/boards/erizo/lowlevel.c
> index fd899c8679..bab49d3c87 100644
> --- a/arch/riscv/boards/erizo/lowlevel.c
> +++ b/arch/riscv/boards/erizo/lowlevel.c
> @@ -9,7 +9,9 @@ ENTRY_FUNCTION(start_erizo_generic, a0, a1, a2)
>  {
>  	extern char __dtb_z_erizo_generic_start[];
>  
> +#if defined CONFIG_DEBUG_LL
>  	debug_ll_ns16550_init();
> +#endif
>  	barebox_nmon_entry();
>  
>  	putc_ll('>');
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox




[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux