On Sun, Apr 18, 2021 at 01:34:09AM +0200, Jules Maselbas wrote: > link_path_walk was returning 0 when passed with an empty path, > this lead calling code to assume that the struct nameidata nd > is valid and thus has a `last` field populated, which is not. > In the end causing a runtime crash. > > This issue can easily be reproduced by running the command: > cat "" > > Reported-by: Neeraj Pal <neerajpal09@xxxxxxxxx> > Signed-off-by: Jules Maselbas <jmaselbas@xxxxxxxxx> > --- > fs/fs.c | 2 ++ > 1 file changed, 2 insertions(+) Applied, thanks Sascha > > diff --git a/fs/fs.c b/fs/fs.c > index a02332491..6de5a3b59 100644 > --- a/fs/fs.c > +++ b/fs/fs.c > @@ -1928,6 +1928,8 @@ static int link_path_walk(const char *name, struct nameidata *nd) > int err; > char separator = '/'; > > + if (!*name) > + return -ENOENT; > while (*name=='/') > name++; > if (!*name) > -- > 2.17.1 > > > > _______________________________________________ > barebox mailing list > barebox@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
