Re: [PATCH] ARM: dts: imx6qdl: pfla02: Update spi-nor naming for kernel compatibility

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Yunus,

On 03.05.21 14:25, Yunus Bas wrote:
> The kernel NVMEM-subsystem prevents the usage of duplicate partition names.
> Change the SPI-NOR partition names to be compatible with the kernel
> driver.

I don't mind the change, but I can't follow the reasoning.
These are MTD partitions, so they shouldn't have been registered with the NVMEM
framework in the first place?

Cheers,
Ahmad

> 
> Commit 72ba815bf6fe ("ARM: dts: phycore-imx6: change mtd-partition names for
> compatibility with kernel") applies the change for phyCORE SOMs. The
> same applies for phyFLEX-modules.
> 
> Signed-off-by: Yunus Bas <y.bas@xxxxxxxxx>
> ---
>  arch/arm/dts/imx6qdl-phytec-pfla02.dtsi | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi
> index e1aa3183b..6df8d247b 100644
> --- a/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi
> +++ b/arch/arm/dts/imx6qdl-phytec-pfla02.dtsi
> @@ -21,7 +21,7 @@
>  
>  		environment-spinor {
>  			compatible = "barebox,environment";
> -			device-path = &som_flash, "partname:barebox-environment";
> +			device-path = &som_flash, "partname:nor.barebox-environment";
>  			status = "disabled";
>  		};
>  
> @@ -54,28 +54,29 @@
>  /delete-node/ &{/memory@10000000};
>  
>  &som_flash {
> +
>  	partitions {
>  		compatible = "fixed-partitions";
>  		#address-cells = <1>;
>  		#size-cells = <1>;
>  
>  		partition@0 {
> -			label = "barebox";
> +			label = "nor.barebox";
>  			reg = <0x0 0x100000>;
>  		};
>  
>  		partition@100000 {
> -			label = "barebox-environment";
> +			label = "nor.barebox-environment";
>  			reg = <0x100000 0x20000>;
>  		};
>  
>  		partition@120000 {
> -			label = "oftree";
> +			label = "nor.oftree";
>  			reg = <0x120000 0x20000>;
>  		};
>  
>  		partition@140000 {
> -			label = "kernel";
> +			label = "nor.kernel";
>  			reg = <0x140000 0x0>;
>  		};
>  	};
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux