Hello Ahmad, On Wed, Apr 21, 2021 at 5:02 PM Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> wrote: > Please send this as Git patch, i.e. with a commit message. This is most > easily done, by using git send-email. Write something in the commit message > that explains the change, e.g.: > > Network configuration on sandbox requires some extra steps on the host > OS. Document these. > > And don't forget your Signed-off-by. You should also mark the patch as v2 > (pass -v2 to git send-email if you use that). Thank you for sharing the information. I didn't use git send-email before but good to know about it. > > I am not sure Sphinx likes it when the line is longer than the > text. Please adjust and while at it you could drop the "for Sandbox" > part. The whole file (and resulting page) is about sandbox. > > s/sanbox/sandbox/. Do you do do these steps while sandbox is running? > If so, it might be better written as While sandbox is running, ... etc. > > > +through dhcp. > > +Following configuration tested on Ubuntu 20.04 focal LTS > > I think you can safely omit this line, but it doesn't hurt. > > The rest looks fine. > > Cheers, > Ahmad I have made the necessary changes as per your suggestions. Sending a complete patch through git send-email. Thanks and regards, Neeraj _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
