On Tue, Apr 13, 2021 at 05:04:14PM +0200, Ahmad Fatoum wrote: > Hello Sascha, > > On 13.04.21 15:40, Sascha Hauer wrote: > > Hi Lars, > > > > On Tue, Apr 13, 2021 at 11:23:40AM +0200, Lars Pedersen wrote: > >> Select CONFIG_POWER_RESET_GPIO_RESTART for Kamstrup mx7 concentrator > >> board. > >> > >> Signed-off-by: Lars Pedersen <lapeddk@xxxxxxxxx> > >> Reviewed-by: Bruno Thomsen <bruno.thomsen@xxxxxxxxx> > >> --- > >> Requires patch ARM: i.MX: Kamstrup mx7 concentrator board support > >> > >> arch/arm/mach-imx/Kconfig | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig > >> index cc73d0a0d..4ee8ffe4b 100644 > >> --- a/arch/arm/mach-imx/Kconfig > >> +++ b/arch/arm/mach-imx/Kconfig > >> @@ -530,6 +530,7 @@ config MACH_KAMSTRUP_MX7_CONCENTRATOR > >> bool "Kamstrup i.MX7 Concentrator" > >> select ARCH_IMX7 > >> select ARM_USE_COMPRESSED_DTB > >> + select CONFIG_POWER_RESET_GPIO_RESTART > > > > I wouldn't select it. CONFIG_POWER_RESET_GPIO_RESTART depends on other > > options and Kconfig can't automatically select the dependencies. > > GPIOLIB is selected via ARCH_IMX. This leaves OFDEVICE=n, which > wouldn't be a valid configuration anyway for this board and probably > all of imx_v7_defconfig..? Should maybe IMX_MULTI_BOARDS select it? > > > Also if you don't want to make use of the gpio restart driver then you > > don't want to be forced to compile it in. > > If a board deems reset important enough to force it when enabled, > why not? With that reasoning you could enable each and everything from a board. I don't think that's a path we want to go. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
