Re: [PATCH v2 14/20] RISC-V: erizo: migrate to PBL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 20.03.21 06:55, Antony Pavlov wrote:
> On Fri, 19 Mar 2021 19:28:10 +0100
> Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> wrote:
> 
> Hi!
> 
>> Hello Antony,
>>
>> On 19.03.21 16:37, Antony Pavlov wrote:
>>> The first bad commit is 90cde3b9ff46 ("startup: Execute init scripts in alphabetical order").
>>> I have reproduced it with these compilers:
>>>
>>>   * riscv32-unknown-elf-gcc (GCC) 7.2.0
>>>   * riscv64-linux-gnu-gcc (Debian 8.3.0-2) 8.3.0
>>>   * riscv64-linux-gnu-gcc-9 (Debian 9.3.0-18) 9.3.0
>>
>> Thanks for investigating. !CONFIG_GLOB && !CONFIG_SHELL_NONE configurations
>> were universally broken. I just sent out a series to fix this.
> 
> I propose to investigate another glob-related issues:
> 
> 1. there is CONFIG_FAKE_GLOB in the C code but no FAKE_GLOB definition in Kconfig.
> 
> 2. we have at least two fake glob() functions:
> 
>    * lib/glob.c contains one glob() definition under '#ifdef CONFIG_FAKE_GLOB'
>    * common/hush.c contains static fake_glob()

Ye, those could be deleted now, I guess.

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux