Re: [PATCH v2 1/2] usb: gadget: dfu: Rework print messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 16, 2021 at 10:19:00AM +0100, Bartosz Bilas wrote:
> Hello Jules,
> 
> On 15.02.2021 15:18, Jules Maselbas wrote:
> > Replace printf with pr_err and debug with pr_debug.
> > Defines "dfu :" as a prefix for formatted prints.
> > 
> > ---
> > v1 -> v2:
> >   - add `pr_fmt(fmt) "dfu: " fmt`
> >   - change debug call to pr_debug
> >   - remove "dfu: " in print messages
> > 
> > Signed-off-by: Jules Maselbas <jmaselbas@xxxxxxxxx>
> > ---
> >   drivers/usb/gadget/dfu.c | 11 ++++++-----
> >   1 file changed, 6 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/usb/gadget/dfu.c b/drivers/usb/gadget/dfu.c
> > index 9d6a9d252..fba4ad782 100644
> > --- a/drivers/usb/gadget/dfu.c
> > +++ b/drivers/usb/gadget/dfu.c
> > @@ -32,6 +32,7 @@
> >    *   checking?
> >    * - make 'dnstate' attached to 'struct usb_device_instance'
> >    */
> > +#define pr_fmt(fmt) "dfu: " fmt
> >   #include <dma.h>
> >   #include <asm/byteorder.h>
> > @@ -209,7 +210,7 @@ dfu_bind(struct usb_configuration *c, struct usb_function *f)
> >   	dfu->dnreq = usb_ep_alloc_request(c->cdev->gadget->ep0);
> >   	if (!dfu->dnreq) {
> > -		printf("usb_ep_alloc_request failed\n");
> > +		pr_err("dfu: usb_ep_alloc_request failed\n");
> 
> you have missed this one ^^^^^

Fixed while applying, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux