Re: [PATCH] imd: change disabled checksum tag info to debug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 12, 2021 at 10:38:01AM +0100, Steffen Trumtrar wrote:
> From: Steffen Trumtrar <s.trumtrar@xxxxxxxxxxxxxx>
> 
> When the checksum tag is disabled the CRC is most likely invalid.
> And if the checksum tag is disabled and the CRC is actually invalid the
> user doesn't care for it anyway.
> 
> This information only confuses the user so make it a debug message.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@xxxxxxxxxxxxxx>
> ---
>  common/imd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks

Sascha

> 
> diff --git a/common/imd.c b/common/imd.c
> index ef9eff876b..aff3b00b6b 100644
> --- a/common/imd.c
> +++ b/common/imd.c
> @@ -406,7 +406,7 @@ int imd_verify_crc32(void *buf, size_t size)
>  			       *p, crc);
>  			return -EILSEQ;
>  		} else if (*p != crc && !imd_crc32_is_valid(*flags)) {
> -			printf("CRC: is invalid, but the checksum tag is not enabled\n");
> +			debug("CRC: is invalid, but the checksum tag is not enabled\n");
>  			return -EINVAL;
>  		} else {
>  			printf("CRC: valid\n");
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux