Re: [PATCH] i.MX: HABv4: Improve HAB event printing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sascha,

On 2020-11-24 08:57, robin wrote:
Hi Sascha,

On 2020-11-23 17:38, Sascha Hauer wrote:
Instead of using a fixed sized buffer for the report_event function,
let's call it two times, once with a NULL pointer to get the size of the
event and a second time with a buffer of that size.
Also, instead of separating the events into warning and error type,
iterate over all events in one single loop. This helps to get the events
in the order they occured which probably helps the reader to make more
sense of them.

Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>

Even better!

Is it worth mentioning that this also fixes the unjustified
'Recompile with larger event data buffer' error?

Acked-by: Robin van der Gracht

I just noticed your previous email. I'll test this today.

Regards Robin

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux