Hi,
> I've rewritten this thing a little bit. First of all, this doesn't need
> preprocessor tricks and also with this the nfserror to error mapping
> function returns the error string, so we can convert printing the
> messages to pr_* or dev_* functions. Also we use the human readable
> error names for the errors we have a string for.
>
Nice to here that there is progress.
> +
> +static const char *nfserrstr(u32 nfserror, int *errcode)
> +{
Instead using this Preprocessor thing wouldn't it be better to use a number and
sizeof(str) at the other locations?
> + static char str[BUFLEN];
static char str[32];
here
> + snprintf(str, BUFLEN, "NFS3ERR_%s", err->name);
snprintf(str, sizeof(str), "NFS3ERR_%s", err->name);
and here
> + snprintf(str, BUFLEN, "Unknown NFS error %d", nfserror);
snprintf(str, sizeof(str), "Unknown NFS error %d", nfserror);
and Remove this:
> +#define BUFLEN 32
> +#undef BUFLEN
--
Regards
Gavin Schenk
Eckelmann AG
Vorstand: Dipl.-Ing. Peter Frankenbach (Sprecher) Dipl.-Wi.-Ing. Philipp Eckelmann
Dr.-Ing. Marco Münchhof Dr.-Ing. Frank Uhlemann
Vorsitzender des Aufsichtsrats: Hubertus G. Krossa Stv. Vorsitzender des Aufsichtsrats: Dr.-Ing. Gerd Eckelmann
Sitz der Gesellschaft: Berliner Str. 161, 65205 Wiesbaden, Amtsgericht Wiesbaden HRB 12636
www.eckelmann.de
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
