Hi,
thanks a lot, that's great.
On Tue, Oct 27, 2020 at 10:42:42AM +0100, Sascha Hauer wrote:
> In case the USB device is a full speed device we have to set
> dev->epmaxpacketin[0] and dev->epmaxpacketout[0] before doing a
> get_descriptor_len() because otherwise it's unset during that call.
>
> Fixes: 6d1d95a386 ("usb: factor out a usb_setup_descriptor() function")
> Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
Tested-by: Gavin Schenk <g.schenk@xxxxxxxxxxxx>
On one of our i.MX25 based platforms there are currently four revert commits to
make USB work on barebox 2020.06.
(Reverted commits are:)
62d565ba0 (usb: hub: When no connection came up remove from scanning list)
1f8c8af48 (usb: Add super speed support)
bb2cbfb2b (usb: hub: Translate USB 3.0 hub port status into old version)
6d1d95a38 (usb: factor out a usb_setup_descriptor() function)
Without reverting the behaviour is:
usb: USB: scanning bus for devices...
usb1: Bus 001 Device 001: ID 0000:0000 EHCI Host Controller
ERROR: usb1-0: unable to get device descriptor (error=-110)
ERROR: usb1-0: USB device not accepting new address (error=80000000)
usb: 1 USB Device(s) found
With this patch applied USB is working again:
usb: USB: scanning bus for devices...
usb1: Bus 001 Device 001: ID 0000:0000 EHCI Host Controller
usb1-0: Bus 001 Device 002: ID 0951:161a DataTraveler 410
Using index 0 for the new disk
usb: 2 USB Device(s) found
barebox@Eckelmann AG ECU02:/ ls /mnt/usbstorage/
. ..
.Trash-1000 2016-barebox-eag-ecu02.img
2020-barebox-eckelmann-ecu02.img barebox-eag-ecu02.img
Regards
Gavin Schenk
Eckelmann AG
Vorstand: Dipl.-Ing. Peter Frankenbach (Sprecher) Dipl.-Wi.-Ing. Philipp Eckelmann
Dr.-Ing. Marco Münchhof Dr.-Ing. Frank Uhlemann
Vorsitzender des Aufsichtsrats: Hubertus G. Krossa Stv. Vorsitzender des Aufsichtsrats: Dr.-Ing. Gerd Eckelmann
Sitz der Gesellschaft: Berliner Str. 161, 65205 Wiesbaden, Amtsgericht Wiesbaden HRB 12636
www.eckelmann.de
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
