Re: [PATCH 1/5] treewide: fix unterminated of_device_id[] reported by Coccinelle

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 01, 2020 at 09:43:33AM +0200, Ahmad Fatoum wrote:
> driver_d::of_compatible outght to point at a NULL-terminated array.
> Fix instances where this is not the case.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
> ---
>  drivers/firmware/socfpga.c       | 1 +
>  drivers/firmware/zynqmp-fpga.c   | 1 +
>  drivers/serial/serial_clps711x.c | 1 +
>  3 files changed, 3 insertions(+)

Applied, thanks

Sascha

> 
> diff --git a/drivers/firmware/socfpga.c b/drivers/firmware/socfpga.c
> index 6d11da32a5f7..234fb2d0945f 100644
> --- a/drivers/firmware/socfpga.c
> +++ b/drivers/firmware/socfpga.c
> @@ -471,6 +471,7 @@ static struct of_device_id fpgamgr_id_table[] = {
>  	{
>  		.compatible = "altr,socfpga-fpga-mgr",
>  	},
> +	{ /* sentinel */ }
>  };
>  
>  static struct driver_d fpgamgr_driver = {
> diff --git a/drivers/firmware/zynqmp-fpga.c b/drivers/firmware/zynqmp-fpga.c
> index e02667355f82..ab70d99933b6 100644
> --- a/drivers/firmware/zynqmp-fpga.c
> +++ b/drivers/firmware/zynqmp-fpga.c
> @@ -403,6 +403,7 @@ static struct of_device_id zynqmpp_fpga_id_table[] = {
>  	{
>  		.compatible = "xlnx,zynqmp-pcap-fpga",
>  	},
> +	{ /* sentinel */ }
>  };
>  
>  static struct driver_d zynqmp_fpga_driver = {
> diff --git a/drivers/serial/serial_clps711x.c b/drivers/serial/serial_clps711x.c
> index 7a7d595dff93..294c88b92fdd 100644
> --- a/drivers/serial/serial_clps711x.c
> +++ b/drivers/serial/serial_clps711x.c
> @@ -184,6 +184,7 @@ out_err:
>  
>  static struct of_device_id __maybe_unused clps711x_uart_dt_ids[] = {
>  	{ .compatible = "cirrus,ep7209-uart", },
> +	{ /* sentinel */ }
>  };
>  
>  static struct driver_d clps711x_driver = {
> -- 
> 2.28.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux