On 9/28/20 5:32 PM, Sascha Hauer wrote: > On Mon, Sep 28, 2020 at 04:59:40PM +0200, Ahmad Fatoum wrote: >> On 9/28/20 4:58 PM, Sascha Hauer wrote: >>> On Mon, Sep 28, 2020 at 04:41:45PM +0200, Ahmad Fatoum wrote: >>>> We don't have anything that test_kasan.o can be generated out of, >>>> thus drop it to fix the build. >>>> >>>> It would still be nice to have this as a command, but that >>>> should be a separate patch. >>>> >>>> Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> >>>> --- >>>> lib/kasan/Makefile | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> I prefer to add the code that I have forgotten to git add ;) >> >> Wouldn't locating it in commands/ be better? > > It uses internal KASan functions. Putting it into commands would mean > that we have to include "../lib/kasan/kasan.h". That's possible of > course, but I thought it looks better that way. Ok. > > Sascha > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
