Hello Trent, On 9/11/20 7:50 PM, Trent Piepho wrote: >>> On 9/9/20 9:36 PM, Trent Piepho wrote: >>> Change the channel naming to use the device instance name, e.g. >>> "aiodev0", rather than the aiodev's base name. This makes the names >>> used aiochannel_get_by_name() match the environment variable names and >>> also avoids duplicate names with more than one dynamically allocated >>> aiodev. >> >> sounds good, but that would silently break existing users, wouldn't i? >> There are none in-tree, but I assume there are some in external patch >> stacks, otherwise the function would've not been added. >> >> These patch stacks would rebase cleanly and build successfully, but >> still be runtime broken. Would it makes sense to rename >> aiochannel_get_by_name() because the API changed? > > Assuming they used dynamic names for the devices. So probably. > > I can rename it to aiochannel_by_name(). There are number of other > functions in barebox that follow that pattern. Ack. > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
