Re: [PATCH] console_countdown: Add CR as valid return key

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jules,

On Thu, Jul 16, 2020 at 03:27:53PM +0200, Jules Maselbas wrote:
> Now both LF ('\n') and CR ('\r') are valid keys to abort
> console_countdown when using CONSOLE_COUNTDOWN_RETURN flag.

I have no problem with this change, but out of curiosity: In which case
do you need it?

Regards,
 Sascha

> 
> Signed-off-by: Jules Maselbas <jmaselbas@xxxxxxxxx>
> ---
>  common/console_countdown.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/console_countdown.c b/common/console_countdown.c
> index 74dc38279..b92948f50 100644
> --- a/common/console_countdown.c
> +++ b/common/console_countdown.c
> @@ -64,7 +64,7 @@ int console_countdown(int timeout_s, unsigned flags, const char *keys,
>  					goto out;
>  				if (flags & CONSOLE_COUNTDOWN_ANYKEY)
>  					goto out;
> -				if (flags & CONSOLE_COUNTDOWN_RETURN && key == '\n')
> +				if (flags & CONSOLE_COUNTDOWN_RETURN && (key == '\n' || key == '\r'))
>  					goto out;
>  				if (flags & CONSOLE_COUNTDOWN_CTRLC && key == 3)
>  					goto out;
> -- 
> 2.17.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux