On 20-08-04 23:41, Anees Rehman wrote: ... > +static noinline void imx7d_sxb_sram_setup(void) > +{ > + int ret; > + > + relocate_to_current_adr(); > + setup_c(); > + > + pr_debug("configuring ddr...\n"); > + write_regs(imx7d_ixb_dcd, ARRAY_SIZE(imx7d_ixb_dcd)); > + > + ret = imx7_esdhc_start_image(2); > + > + BUG_ON(ret); > +} > + > +ENTRY_FUNCTION(start_ac_sxb, r0, r1, r2) > +{ > + imx7_cpu_lowlevel_init(); > + > + if (IS_ENABLED(CONFIG_DEBUG_LL)) > + setup_uart(); > + > + if (get_pc() < 0x80000000) > + imx7d_sxb_sram_setup(); Nit: After this call we are running in the correct place... > + imx7d_barebox_entry(__dtb_z_ac_sxb_start + get_runtime_offset()); So get_runtime_offset() shouldn't be necessary if I got it right. > +} Regards, Marco _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox